Skip to content

chore: update dependencies + run prettier on codebase #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 21, 2020
Merged

chore: update dependencies + run prettier on codebase #234

merged 2 commits into from
Sep 21, 2020

Conversation

MichaelDeBoey
Copy link
Member

BREAKING CHANGE: Requires Node@^10.22.1 || 12.x
BREAKING CHANGE: Requires ESLint@^7.5.x

@MichaelDeBoey
chore: update dependencies
1922cec 
BREAKING CHANGE: Requires Node@^10.22.1 || 12.x
BREAKING CHANGE: Requires ESLint@^7.5.x
@MichaelDeBoey
chore: run Prettier on full codebase
057e509
@Belco90 Belco90 added the BREAKING CHANGE This change will require a major version bump label Sep 20, 2020
@Belco90 Belco90 added this to the v4 milestone Sep 20, 2020
@Belco90
Copy link
Member

Belco90 commented Sep 20, 2020

Tons of dev dependencies bumped. Are we sure we are not affected by any of their breaking changes? They'll be probably removing node v8 support and similar stuff, but still.

@MichaelDeBoey
Copy link
Member Author

@Belco90 I checked them all out and only Node versions are really breaking in our case

Belco90
Belco90 approved these changes Sep 21, 2020
View reviewed changes
Copy link
Member

@Belco90 Belco90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this one. Could you clarify why the minimum node version went from 10.12.0 to 10.22.1 please?

@Belco90 Belco90 merged commit 9c2072d into testing-library:v4 Sep 21, 2020
@Belco90
Copy link
Member

Belco90 commented Sep 21, 2020

@all-contributors please add @MichaelDeBoey for maintenance

@allcontributors allcontributors bot mentioned this pull request Sep 21, 2020
Merged
@allcontributors
Copy link
Contributor

@Belco90

I've put up a pull request to add @MichaelDeBoey! 🎉

@MichaelDeBoey
Copy link
Member Author

@Belco90 It's because of the @commitlint/cli dependency

@MichaelDeBoey MichaelDeBoey deleted the update-dependencies branch September 21, 2020 08:25
@Belco90
Copy link
Member

Belco90 commented Sep 21, 2020

That's just a dev dependency, it's not a breaking change then.

@MichaelDeBoey
Copy link
Member Author

@Belco90 It is, but >=10.22.1 is needed in order to being able to work on this package locally

@Belco90
Copy link
Member

Belco90 commented Sep 21, 2020

Sure, but won't be a breaking change for users using this package. So we need to remember to exclude that breaking change message to arrive to the final release.

@github-actions
Copy link

🎉 This PR is included in version 4.0.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@MichaelDeBoey MichaelDeBoey added chore Changes that affect the build system, CI config or other changes that don't modify src/test files dependencies Pull requests that update a dependency file labels Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Belco90 Belco90 Belco90 approved these changes

Assignees
No one assigned
Labels
BREAKING CHANGE This change will require a major version bump chore Changes that affect the build system, CI config or other changes that don't modify src/test files dependencies Pull requests that update a dependency file released on @beta released
Projects
None yet
Milestone
v4
Development

Successfully merging this pull request may close these issues.
2 participants
@MichaelDeBoey @Belco90